This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH, libstdc++v3]: Fallback to read/write ops in case sendfile fails with ENOSYS or EINVAL.

From: Uros Bizjak <ubizjak at gmail dot com>
To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, Jonathan Wakely <jwakely at redhat dot com>
Date: Thu, 11 Aug 2016 21:27:24 +0200
Subject: [PATCH, libstdc++v3]: Fallback to read/write ops in case sendfile fails with ENOSYS or EINVAL.
Authentication-results: sourceware.org; auth=none

Hello!

Attached patch implements note from sendfile manpage:

<q>
Applications may wish to fall back to read(2)/write(2) in the case
where sendfile() fails with EINVAL or ENOSYS.
</q>

Also, the patch fixes a small inconsistency in how
_GLIBCXX_USE_FCHMODAT config flag is handled in do_copy_file function.

2016-08-11  Uros Bizjak  <ubizjak@gmail.com>

    * src/filesystem/ops.cc: Always include ostream and
    ext/stdio_filebuf.h.
    (do_copy_file): Check if _GLIBCXX_USE_FCHMODAT is defined.
    [_GLIBCXX_USE_SENDFILE]: Fallback to read/write operations in case
    sendfile fails with ENOSYS or EINVAL.

Patch was bootstrapped and regression tested on x86_64-linux-gnu
{,-m32} on CentOS 5.11 (where sendfile returns EINVAL for file->file
copy) and Fedora 24. In addition, the patch was bootstraped and
regression tested with _GLIBCXX_USE_SENDFILE manually disabled after
configure.

OK for mainline?

Uros.

Attachment: l.diff.txt
Description: Text document

Follow-Ups:
- Re: [PATCH, libstdc++v3]: Fallback to read/write ops in case sendfile fails with ENOSYS or EINVAL.
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]