This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH RFC] do not throw in std::make_exception_ptr

On Wed, Aug 3, 2016 at 8:36 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 03/08/16 15:02 +0300, Gleb Natapov wrote:
>>
>> On Wed, Aug 03, 2016 at 12:47:30PM +0100, Jonathan Wakely wrote:
>>> Huh. If I'm reading the ABI spec correctly, we should terminate if the
>>> copy constructor throws.
>>>
>> I'll make it terminate like you've suggested then.
>
> Let's leave it as you had it originally. I'm not sure if my reading of
> the ABI is correct, so let's keep the behaviour consistent for now.
>
> We can always revisit it later if we decide terminating is correct.

Terminating is not correct, the ABI document is out of date: CWG 475
(wg21.link/cwg475) clarified that terminate is not called if the copy
constructor throws while initializing the exception object.

Jason
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]