This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Define feature-test macro for std::enable_shared_from_this
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 5 Aug 2016 14:57:50 +0100
- Subject: Re: [PATCH] Define feature-test macro for std::enable_shared_from_this
- Authentication-results: sourceware.org; auth=none
- References: <20160803191125.GA4351@redhat.com> <20160804123307.GT4264@redhat.com>
On 04/08/16 13:33 +0100, Jonathan Wakely wrote:
On 03/08/16 20:11 +0100, Jonathan Wakely wrote:
Another feature we already support, so just define the macro.
* include/bits/shared_ptr_base.h (__cpp_lib_enable_shared_from_this):
Define feature-test macro.
* testsuite/20_util/enable_shared_from_this/members/reinit.cc: Test
for the macro.
Tested x86_64-linux, committed to trunk.
I realised we don't actually implement the whole feature, because we
don't have the new weak_from_this() members (careless of me to forget
the contents of my own proposal!)
This adds them for C++17, or gnu++1*, and only defines the
feature-test macro when those members are present.
And this corrects the status in the manual.
commit bdf5a745f3f98517fc0efe3f5daef9da0b8b53c7
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Aug 5 14:56:34 2016 +0100
Correct status of __cpp_lib_enable_shared_from_this
* doc/xml/manual/status_cxx2017.xml: Correct shared_from_this status.
* doc/html/manual/status.html: Regenerate.
diff --git a/libstdc++-v3/doc/xml/manual/status_cxx2017.xml b/libstdc++-v3/doc/xml/manual/status_cxx2017.xml
index 4d098d1..02aec25 100644
--- a/libstdc++-v3/doc/xml/manual/status_cxx2017.xml
+++ b/libstdc++-v3/doc/xml/manual/status_cxx2017.xml
@@ -261,7 +261,7 @@ Feature-testing recommendations for C++</link>.
P0033R1
</link>
</entry>
- <entry align="center"> 6.1 </entry>
+ <entry align="center"> 7 </entry>
<entry><code>__cpp_lib_enable_shared_from_this >= 201603</code></entry>
</row>