This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] c++/58796 Make nullptr match exception handlers of pointer type

From: Jonathan Wakely <jwakely at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>
Date: Fri, 15 Jul 2016 22:53:41 +0100
Subject: Re: [PATCH] c++/58796 Make nullptr match exception handlers of pointer type
Authentication-results: sourceware.org; auth=none
References: <20160715114735.GQ12493@redhat.com> <20160715210702.GR12493@redhat.com> <20160715213657.GY7387@tucnak.redhat.com>

On 15/07/16 23:36 +0200, Jakub Jelinek wrote:

On Fri, Jul 15, 2016 at 10:07:03PM +0100, Jonathan Wakely wrote:

>+      if (typeid (*this) == typeid(__pointer_type_info))
>+        {
>+          *thr_obj = nullptr;
>+          return true;


But you have the above store too.


That doesn't write to the exception object, it only does a single
dereference (compared to the double dereference of the racy write), so
it writes to the local variable in the PERSONALITY_FUNCTION in
eh_personality.cc

So that shouldn't race with other threads. I think.

Follow-Ups:
- Re: [PATCH] c++/58796 Make nullptr match exception handlers of pointer type
  - From: Jonathan Wakely

References:
- [PATCH] c++/58796 Make nullptr match exception handlers of pointer type
  - From: Jonathan Wakely
- Re: [PATCH] c++/58796 Make nullptr match exception handlers of pointer type
  - From: Jonathan Wakely
- Re: [PATCH] c++/58796 Make nullptr match exception handlers of pointer type
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]