Re: Improve insert/emplace robustness to self insertion

[Jonathan Wakely <jwakely at redhat dot com>]

On 09/07/16 20:29 -0400, David Edelsohn wrote:
> On Sat, Jul 9, 2016 at 7:59 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
> > On 09/07/16 13:47 -0400, David Edelsohn wrote:
> > > This patch has caused some new libstdc++ testsuite failures on AIX.
> >
> >
> > Which patch?
> >
> > My last patch only added a new test, that can't have caused failures
> > in unrelated tests.
> >
> > https://gcc.gnu.org/ml/libstdc++-cvs/2016-q3/msg00021.html
>
> I thought that there were a recent set of libstdc++ patches related to
> "insert'.

There was one July 4, but nothing since then has been committed, only
discussed. That touched vector::insert, so is highly unlikely to have
changed codegen for __gnu_debug::deque or __gnu_debug::list.

> What else could have caused these regressions?  Recent
> patches to C++ front-end?

Possibly, I've no idea, I haven't been watching the FE commits.

> Thanks, David
>
> > > FAIL: 23_containers/list/debug/insert4_neg.cc (test for excess errors)
> > >
> > > Excess errors:
> > >
> > >
> > > /tmp/20160708/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/formatter.h:387:7:
> > > error: __gnu_debug::_Error_formatter&
> > > __gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
> > > char*) [with _Iterator = __gnu_debug::_Safe_iterator
> > > <std::_List_const_iterator<int>, std::__debug::list<int> >] causes a
> > > section type conflict with __gnu_debug::_Error_formatter&
> > > __gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
> > > char*) [with _Iterator =
> > > __gnu_debug::_Safe_iterator<std::_List_iterator<int>,
> > > std::__debug::list<int> >]
> > >
> > > FAIL: 23_containers/deque/debug/insert4_neg.cc (test for excess errors)
> > >
> > > Excess errors:
> > >
> > >
> > > /tmp/20160708/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/formatter.h:387:7:
> > > error: __gnu_debug::_Error_formatter&
> > > __gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
> > > char*) [with _Iterator = __gnu_debug::_Safe_iterator
> > > <std::_Deque_iterator<int, int&, int*>, std::__debug::deque<int> >]
> > > causes a section type conflict with __gnu_debug::_Error_formatter&
> > > __gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
> > > char*) [with _Iterator =
> > > __gnu_debug::_Safe_iterator<std::_Deque_iterator<int, const int&,
> > > const int*>, std::__debug::deque<int> >]
> > >
> > > Thanks, David