This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3 PATCH] PR libstdc++/68139
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 11 Dec 2015 11:51:25 +0000
- Subject: Re: [v3 PATCH] PR libstdc++/68139
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUZ_dTkYxVWwcNoTVvUF2HNERiEFE73y6SQvByFwab2B_A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1512110754200 dot 1988 at laptop-mg dot saclay dot inria dot fr> <CAFk2RUZ4CkUJcjsBcV=Xqv-AjhpZFJKS07T7hBnqF-h+8X0jhQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1512110851400 dot 1988 at laptop-mg dot saclay dot inria dot fr> <CAFk2RUaNo0a+BRfVxk5Gak5pmT8VW4w8C_zW2yaTkax+E2CJ3g at mail dot gmail dot com>
On 11/12/15 09:53 +0200, Ville Voutilainen wrote:
On 11 December 2015 at 09:52, Marc Glisse <marc.glisse@inria.fr> wrote:
/libstdc++-v3
* libsupc++/nested_exception.h (_S_rethrow): Use __std::addressof.
Typo.
I must be blind, but I don't see what you mean. :)
Shouldn't the underscores apply to addressof, not to the namespace?
Hah! Yes, thanks, I will fix that. :)
And we don't have separate changelogs for the libstdc++ testsuite, so
it should be just:
* libsupc++/nested_exception.h: ...
* testsuite/18_support/nested_exception/68139.cc: ...
Do we already include <bits/move.h> in freestanding implementations?
Even if we don't, I think it's OK to do so, so the patch is OK with a
corrected changelog.