This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] libstdc++/68825 Fix dejagnu directives in shared_ptr test
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Fan You <youfan dot noey at gmail dot com>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Thu, 10 Dec 2015 10:16:07 -0500 (EST)
- Subject: Re: [patch] libstdc++/68825 Fix dejagnu directives in shared_ptr test
- Authentication-results: sourceware.org; auth=none
- References: <20151210143213 dot GC5356 at redhat dot com> <CALvpekE5L69muuH84zDSsN1DYdnGW8sWiJFnVj0Oj8wyq2+7_w at mail dot gmail dot com>
No problem :-)
----- Original Message -----
From: "Fan You" <youfan.noey@gmail.com>
To: "Jonathan Wakely" <jwakely@redhat.com>, libstdc++@gcc.gnu.org
Sent: Thursday, 10 December, 2015 2:45:12 PM
Subject: Re: [patch] libstdc++/68825 Fix dejagnu directives in shared_ptr test
Thank you very much for fixing this! : )
On Thu, Dec 10, 2015 at 9:32 AM Jonathan Wakely <jwakely@redhat.com> wrote:
> This XFAIL test should have been used { dg-do compile } so it doesn't
> get marked UNRESOLVED when it fails to compile. The test was also
> broken, the assignment operator compiled OK, but because the test used
> dg-excess-errors instead of dg-error the later failure for the copy
> construction matched it and made it pass. Changing it to dg-error made
> it FAIL, until I also constrained the assignment operators.
>
> Tested powerpc64le-linux, committed to trunk.
>
> --
Regards,
Fan