This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.
- From: Daniel KrÃgler <daniel dot kruegler at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, FranÃois Dumont <frs dot dumont at gmail dot com>
- Date: Mon, 7 Sep 2015 22:12:54 +0200
- Subject: Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.
- Authentication-results: sourceware.org; auth=none
- References: <20150907182755 dot GP2631 at redhat dot com> <CAGNvRgDDtbEDrNgeyeb3fbFvrB=JJJjSgLeScW1=2ctLZcY1Nw at mail dot gmail dot com> <20150907195300 dot GS2631 at redhat dot com> <20150907201029 dot GU2631 at redhat dot com>
2015-09-07 22:10 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
> On 07/09/15 20:53 +0100, Jonathan Wakely wrote:
>> On 07/09/15 21:04 +0200, Daniel KrÃgler wrote:
>>> In the suggested doc changes:
>>>
>>> + When defined, <code>_GLIBCXX_ASSERTIONS</code> is defined
>>> + automatically, so all the assertions that enables are also
>>> enabled
>>> + in debug mode.
>>>
>>> there seems to be a typo, presumably it should be
>>>
>>> + When defined, <code>_GLIBCXX_ASSERTIONS</code> is defined
>>> + automatically, so all the assertions that <ins>it</ins>
>>> enables are also enabled
>>> + in debug mode.
>>>
>>> instead?
>>
>>
>> It's correct as I wrote it, but your version is clearer so I'll change
>> it.
>>
>> My original can be read as "so all the assertions that that enables"
>> where the first "that" can be removed without changing the meaning.
>> Stoopid English ;-)
>
>
> I think this is even better:
>
> When defined, <code>_GLIBCXX_ASSERTIONS</code> is defined
> automatically, so all the assertions enabled by that macro are
> also enabled in debug mode.
>
> Is that clear?
It's perfect!
Thanks,
- Daniel