This is the mail archive of the
mailing list for the libstdc++ project.
Re: __atomic_futex_unsigned::_M_load_when_not_equal has a 'return' statement with no value, in function returning unsigned int
- From: Torvald Riegel <triegel at redhat dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Patrick Palka <patrick at parcs dot ath dot cx>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 23 Jul 2015 23:54:48 +0200
- Subject: Re: __atomic_futex_unsigned::_M_load_when_not_equal has a 'return' statement with no value, in function returning unsigned int
- Authentication-results: sourceware.org; auth=none
- References: <CA+C-WL-r5b-yq8xPSL8KxgRFy+2Od0wKMD7CNj7T1BGUWVODzw at mail dot gmail dot com> <20150723082103 dot GC21787 at redhat dot com>
On Thu, 2015-07-23 at 09:21 +0100, Jonathan Wakely wrote:
> On 22/07/15 22:30 -0400, Patrick Palka wrote:
> >Specifically, line 149 of atomix_futex.h has a bare "return;"
> >statement, but the function is marked as returning non-void. This was
> >caught while working on PR c++/18969. Vanilla G++ does not catch this
> >error because return statements inside templates are currently only
> >analyzed during instantiation time.
> Ouch. Luckily that function is never called, so it's not doing any
> Torvald, assuming we want to keep that unused function, is this the
> right fix?
I think so. Thanks!