This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch AArch64] Add cpu_defines.h for AArch64.
- From: pinskia at gmail dot com
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 19 May 2015 08:54:02 -0700
- Subject: Re: [Patch AArch64] Add cpu_defines.h for AArch64.
- Authentication-results: sourceware.org; auth=none
- References: <555B327F dot 3090107 at foss dot arm dot com>
> On May 19, 2015, at 5:54 AM, Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com> wrote:
>
> Hi,
>
> Like the ARM port, the AArch64 ports needs to set glibc_integral_traps to false as integer divide instructions do not trap.
>
> Bootstrapped and regression tested on aarch64-none-linux-gnu
>
> Ok to apply ?
Not really questioning your patch but questioning libstdc++'s defaults. I wonder if this should be the default as most targets don't trap, only a few that does. And it should be safer default to say they don't trap too?
Thanks,
Andrew
>
> regards
> Ramana
>
>
> 2015-05-17 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> * configure.host: Define cpu_defines_dir for AArch64
> * config/cpu/aarch64/cpu_defines.h: New file.
> <0002-Do-the-same-for-AArch64.patch>