This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen at google dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 9 Jan 2015 00:42:46 +0000
Subject: Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex
Authentication-results: sourceware.org; auth=none
References: <CAG4ZjN=UdMVQUw2qmT0jCnqfn_Ed-yqCjRPG18HzrnLE-o3p7w at mail dot gmail dot com> <20150107123919 dot GC3360 at redhat dot com> <CAG4ZjN=kJsqeiD98MxA+rqCX0W9gBs-zRsss2p6q65-PPUVp-g at mail dot gmail dot com>

On 08/01/15 11:44 -0800, Tim Shen wrote:

On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely <jwakely@redhat.com> wrote:

No blank line here in the ChangeLog.


Done.

This is swapping iterators, which can be user-defined types, so it
should support finding a swap function by ADL, i.e.


Done.

Also, there should be a new test, since apparently we don't have any
test that tries to call match_results::swap(match_results&).


Done.


Thanks - OK for trunk and 4.9.

References:
- [Patch, libstdc++/64239] Use std::swap instead of swap in regex
  - From: Tim Shen
- Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex
  - From: Jonathan Wakely
- Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]