This is the mail archive of the
mailing list for the libstdc++ project.
Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Daniel Krügler <daniel dot kruegler at gmail dot com>, Tim Shen <timshen at google dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 19 Nov 2014 19:54:28 +0100
- Subject: Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNm2Dj3UbcP1L1fp7BTku2e2zDyDwU1SH4hYSktz5XhbJA at mail dot gmail dot com> <546B9BB3 dot 1010205 at oracle dot com> <CAG4ZjNmhS_55VhA-JX1k2UJM+5eEthpywq8C7qnFQvypvHP=ng at mail dot gmail dot com> <546CC255 dot 5020002 at oracle dot com> <CAG4ZjNk4H3gOqddEuPs9Z+TYJ1VxqMe5Jw+BJ+cdg2NHPf3ZCg at mail dot gmail dot com> <CAGNvRgC961Y_OZtXh74FFy6UR9Tgz5MkHHvbvQNy8AjZsjGZGg at mail dot gmail dot com>
On 11/19/2014 07:43 PM, Daniel Krügler wrote:
I was just aiming for consistency, from a very, very, general point of
view. Jon will review the substance of the patch, anyway.
2014-11-19 19:42 GMT+01:00 Tim Shen <firstname.lastname@example.org>:
On Wed, Nov 19, 2014 at 8:16 AM, Paolo Carlini <email@example.com> wrote:
Good. To be clear, not having carefully analyzed whatsoever, my point was
more about changing _M_end too, to non-const, than about not touching
_M_begin. Would that make sense?
Currently we never mutate _M_end. I *believe* that we still won't in
the future, since _M_end is not as volatile as _M_begin.
I agree with Tim here, why shouldn't the const member and the
non-const member coexist?