This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH C++] - SD-6 Implementation Part 3 - .


On 10/06/2014 05:54 AM, Jonathan Wakely wrote:
On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote:
Index: testsuite/experimental/feat-lib-fund.cc
===================================================================
--- testsuite/experimental/feat-lib-fund.cc    (revision 0)
+++ testsuite/experimental/feat-lib-fund.cc    (working copy)
@@ -0,0 +1,25 @@
+// { dg-options "-std=gnu++14" }
+// { dg-do compile }
+
+#include <experimental/optional>
+#include <experimental/string_view>
+
+#if !__has_include(<experimental/optional>)
+#  error "<experimental/optional>"
+#endif
+
+//#if !__has_include(<experimental/net>)
+//#  error "<experimental/net>"
+//#endif
+
+//#if !__has_include(<experimental/any>)
+//#  error "<experimental/any>"
+//#endif
+
+//#if !__has_include(<experimental/memory_resource>)
+//#  error "<experimental/memory_resource>"
+//#endif
+
+#if !__has_include(<experimental/string_view>)
+#  error "<experimental/string_view>"
+#endif

Hi Ed,

I'm about to commit std::experimental::apply() from the Library
Fundamentals TS and so wanted to add <experimental/tuple> to your new
feat-lib-fund.cc test.
Cool!

Should that test be actually including all the files (as it does for
optional and string_view) or just test for their presence?
Actually, we shouldn't need to include them.  We can remove the includes.

Should the other headers added by the TS be there as well (commented
out for now)? If so it's missing utility, type_traits, ratio, chrono,
system_error, functional, memory, future and algorithm.
That would be a good idea. Maybe for completeness we should have all the C++11 headers maybe in another test file.

Of course, while the files are missing and the tests for the mare
commented out the test can't fail and so only really serves as a
reminder/placeholder for what's missing.

Either way... I kept them in there as a placeholder and yet another progress meter. But we could leave/clean them out too.

Ed


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]