This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonical<unsigned int...>

From: Ed Smith-Rowland <3dw4rd at verizon dot net>
To: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Paolo Carlini <paolo dot carlini at oracle dot com>, Jonathan Wakely <jwakely dot gcc at gmail dot com>
Date: Tue, 29 Jul 2014 04:11:06 -0400
Subject: [PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonical<unsigned int...>
Authentication-results: sourceware.org; auth=none

As discussed in the audit trail both _Adaptor and generate_canonical areboth meant to use floating point values. Both are here givenstatic_asserts to that effect.

This would have prevented this error and might help future users.

The main issue is the use of value_type in _Adaptor and thus ingenerate_canonical in hypergeometric_distribution::operator(). Thisdistribution is a discreet distribution and thus value_type is anunsigned integer which caused overflow in generate_canonical. Inkeeping with practice in all other discreet distributions a double typewill now be used in _Adaptor.

Someday, it might be beneficial to discuss an _IntegralAdaptor and acorresponding __generate_canonical for use in our discreet distributionsbut I want to close this bug with this patch.


Built and tested on x86_64-linux.

OK?

Attachment: CL_pr60037
Description: Text document

Attachment: patch_pr60037
Description: Text document

Follow-Ups:
- Re: [PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonical<unsigned int...>
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]