This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 8 November 2013 16:03, Jonathan Wakely wrote: > On 8 November 2013 15:41, Jonathan Wakely wrote: >> On 8 November 2013 14:51, Daniel Krügler wrote: >>> I have fully not grasped for which T the specializations of >>> __has_contiguous_iter are intended to be used, >> >> Currently, only std::container iterators passed to a basic_regex >> constructor, but in theory the trait could get moved to another header >> and used elsewhere in future. > > Currently the vector<bool> specialization can never be reached, > because std::vector<bool> doesn't use __gnu_cxx::__normal_iterator > (and trying to pass vector<bool>::iterator to a regex ctor fails > anyway) so this is only a theoretical problem if we re-use > __has_contiguous_iter elsewhere. I've fixed the trait anyway, like so: 2013-11-08 Jonathan Wakely <jwakely.gcc@gmail.com> * include/bits/regex_compiler.h (__detail::__has_contiguous_iter): vector<bool> storage is not contiguous. Tested x86_64-linux, committed to trunk.
Attachment:
patch.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |