This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Regex comments


On 28 October 2013 00:23, Tim Shen wrote:
> Thank you for figuring out so many syntax errors, I'll be careful next time.

No problem, I'm always happy to help review the grammar, syntax or
spelling in documentation improvements.


> On Sun, Oct 27, 2013 at 5:38 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>> +  // The order of which states needs to be recursively applied DFS matters,
>> +  // depend on which greedy mode we use.
>>
>> I don't understand this sentence at all, sorry.  Can you explain it in
>> other terms, and I'll try to suggest better phrasing?
>
> +    // _M_alt branch is "match once more", while _M_next is "get me out
> +    // of this quantifier". Executing _M_next first or _M_alt first don't
> +    // mean the same thing, and we need to choose the correct order under
> +    // given greedy mode.

OK, that's clear, thanks!

I'm happy for that latest patch to be committed, thanks for taking the
time to improve the comments.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]