Re: [Patch] Implementation of n3793 <experimental/optional>

[Luc Danton <lucdanton at free dot fr>]

On 2013-10-22 11:46, Paolo Carlini wrote:
> Hi,
>
> On 10/18/2013 08:06 AM, Luc Danton wrote:
> > There are still three tests that unexpectly fail, which prompted me 
> > to file a bug
> > (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58777).
> In order to start making progress on this, can you xfail for now the 
> specific testcases which are failing, with a comment pointing to 
> 58777? Then I can apply your patch to my svn tree. If, besides, the 
> xfails and minor issues like tweaks to the Makefile, testing goes 
> well, I don't see why we shouldn't apply the patch!
>
> Thanks,
> Paolo.

This should do the trick.

>From fc0cb57c89146086c9bba586b3a7e3e70eb757bd Mon Sep 17 00:00:00 2001
From: mickk <mickk@example.com>
Date: Wed, 23 Oct 2013 09:52:34 +0200
Subject: [PATCH] Changed failing tests to XFAIL for the time being.

---
 .../testsuite/experimental/optional/constexpr/make_optional.cc        | 4 +++-
 libstdc++-v3/testsuite/experimental/optional/constexpr/observers/2.cc | 4 +++-
 libstdc++-v3/testsuite/experimental/optional/constexpr/observers/3.cc | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/libstdc++-v3/testsuite/experimental/optional/constexpr/make_optional.cc b/libstdc++-v3/testsuite/experimental/optional/constexpr/make_optional.cc
index 71bd6a2..4b59ba9 100644
--- a/libstdc++-v3/testsuite/experimental/optional/constexpr/make_optional.cc
+++ b/libstdc++-v3/testsuite/experimental/optional/constexpr/make_optional.cc
@@ -1,5 +1,7 @@
 // { dg-options "-std=gnu++1y" }
-// { dg-do compile }
+// XFAIL pending resolution of PR libstdc++/58777
+// { dg-do compile { xfail *-*-* } }
+// { dg-excess-errors "" }
 
 // Copyright (C) 2013 Free Software Foundation, Inc.
 //
diff --git a/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/2.cc b/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/2.cc
index fbc4a0f..3df68d3 100644
--- a/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/2.cc
+++ b/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/2.cc
@@ -1,5 +1,7 @@
 // { dg-options "-std=gnu++1y" }
-// { dg-do compile }
+// XFAIL pending resolution of PR libstdc++/58777
+// { dg-do compile { xfail *-*-* } }
+// { dg-excess-errors "" }
 
 // Copyright (C) 2013 Free Software Foundation, Inc.
 //
diff --git a/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/3.cc b/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/3.cc
index ecf35f3..6528d99 100644
--- a/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/3.cc
+++ b/libstdc++-v3/testsuite/experimental/optional/constexpr/observers/3.cc
@@ -1,5 +1,7 @@
 // { dg-options "-std=gnu++1y" }
-// { dg-do compile }
+// XFAIL pending resolution of PR libstdc++/58777
+// { dg-do compile { xfail *-*-* } }
+// { dg-excess-errors "" }
 
 // Copyright (C) 2013 Free Software Foundation, Inc.
 //
-- 
1.8.1.2