This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch 1/2] Rewrite regex scanner

From: Tim Shen <timshen91 at gmail dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 23 Aug 2013 22:04:35 +0800
Subject: Re: [Patch 1/2] Rewrite regex scanner
References: <CAPrifDmbxT045MDCR04EHh21uhyC3QsmO+-_tF0bAkWst2pRwg at mail dot gmail dot com> <CAH6eHdQh74P2t81Ke5DwQDiDMPHpLB=X0B+2ipdEi+PEcOyzrA at mail dot gmail dot com>

On Fri, Aug 23, 2013 at 5:40 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> I would rearrange the ChangeLog, to put
>
>         * include/bits/regex_executor.tcc: Don't use reference for submatch.
>
> after regex_scanner.tcc, so that the files the _Scanner is moved from
> come immediately before the files it is moved to, otherwise it reads
> like "move _Scanner from ... don't use reference ... here" which
> doesn't make much sense :-)

Hmmm...it turns out there's no specified file order? // I always use
default order before.

So here it is.

By the way, it seems to take surprisingly short time to review; after
all, it's a huge patch.

-- 
Tim Shen

Attachment: changelog
Description: Binary data

Follow-Ups:
- Re: [Patch 1/2] Rewrite regex scanner
  - From: Stephen M. Webb

References:
- [Patch 1/2] Rewrite regex scanner
  - From: Tim Shen
- Re: [Patch 1/2] Rewrite regex scanner
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]