This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Whole regex refactoring and current status
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 08 Aug 2013 18:11:50 +0200
- Subject: Re: [Patch] Whole regex refactoring and current status
- References: <CAPrifDkAoudaXf=Rwu7jGiBa8nWf9HUx-TQUNGe5a0krJ7pUug at mail dot gmail dot com> <yddfvukpklg dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <1f55c618-cefd-40cf-801f-a78767b7da3a at email dot android dot com> <ydd7gfwpcw5 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <36da751e-c2dc-488b-a03d-98fc53b4d24e at email dot android dot com> <CAPrifDnE5Avuf_EQVBkB5D8+GngAggQ0oNkbVUmUELe4m9ALeA at mail dot gmail dot com> <CAPrifD=5siXuEpmw9G-VL8qtWmzx3JSM+jbKZcp26vuuZM3nZQ at mail dot gmail dot com> <24b3b4c4-9dda-43cd-a7e8-139be29f315e at email dot android dot com> <CAPrifDkkYCN_2sCKt2f1-dopQnktCQzrBn9UjeKJKbBfaOPLkg at mail dot gmail dot com>
Hi,
>So flag_type shall not be the same as size_t. I don't know if when I
>switch flag_type from unsigned int to, say, unsigned short, conflicts
>will appear in 16bit archtectures.
Well 16-bit archs aren't really supported these days, as long as the c++ runtime is concerned. Thus if unsigned short works let's go with it and move on. In any case, we don't have to make a super final decision, but breaking 32 bit is bad.
In general, I would recommend being careful with adding templated containers, remember that eventually we want to have a lot of code in *.cc files and instantiations will be a big big annoyance.
Paolo