This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Whole regex refactoring and current status

From: Tim Shen <timshen91 at gmail dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 6 Aug 2013 09:21:06 +0800
Subject: Re: [Patch] Whole regex refactoring and current status
References: <CAPrifDkAoudaXf=Rwu7jGiBa8nWf9HUx-TQUNGe5a0krJ7pUug at mail dot gmail dot com> <52001184 dot 5020707 at oracle dot com>

On Tue, Aug 6, 2013 at 4:56 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:

> Why? Isn't a new file, thus 2010-2013 seems just fine.

It's an accident, sorry.

> +
> +  // TODO implement it.
> +  template<typename _BiIter>
> +    void
> +    _Scanner<_BiIter>::
> +    _M_eat_escape()
>
> The comment is quite mysterious! A lot of code is already there, and first
> blush isn't clear at all what is missing and what already works.

Um, What I mean is, it does some things but the support to escaping is
not complete;
I changed the comment to "TODO complete it."


-- 
Tim Shen

Attachment: regex.patch
Description: Binary data

Follow-Ups:
- Re: [Patch] Whole regex refactoring and current status
  - From: David Kastrup

References:
- [Patch] Whole regex refactoring and current status
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]