This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Refractor Thompson matcher
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 31 Jul 2013 00:10:07 +0200
- Subject: Re: [Patch] Refractor Thompson matcher
- References: <CAPrifDmj7BcdDpcJm==v5MtLHnxHzZYCcH9mdywU20P9oU=EpA at mail dot gmail dot com> <51F4E072 dot 9050706 at oracle dot com> <CAPrifDm0fMu1q9mw6PEbqTTvP-oVgckXaqRs+yLwAYwMi3W_2A at mail dot gmail dot com> <51F5202A dot 4050005 at oracle dot com> <CAPrifD=Kxa-nOcBaqmnntqz0Bhn3+4bCT=hikLeJtTq1HwHmRQ at mail dot gmail dot com> <51F5502B dot 7010304 at oracle dot com> <CAPrifDnCeu0cNf8oE2_jQKpVCkWkWcxLe4amcvY7Ye5YkEgUBw at mail dot gmail dot com> <51F6273D dot 7080102 at oracle dot com> <CAPrifDmQ8Ec48+1C_k8kFRE+VkXg2E73T289ntaq-EzgoQ0-xg at mail dot gmail dot com> <51F7F212 dot 1010509 at oracle dot com> <51F7F44C dot 5000401 at oracle dot com>
Hi again,
I reverted the commit and tested that mainline is fine again.
Just to clarify how we normally handle these issues in v3: *temporarily*, to avoid the linkage issues which broke the bootstrap today, all the non-template functions must be inline, even if large. In the past normally we had the definitions of such functions in *.tcc files, thus explicitly inline, with FIXME comments. I think it makes sense to do this for regex too. In any case, as soon as the design stabilizes all such functions shall be exported by the dynamic library, thus in practice all the definitions will be moved to src/c++11/*.cc files.
Thanks,
Paolo