This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Unordered container insertion hints
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Jun 2013 12:46:02 +0100
- Subject: Re: Unordered container insertion hints
- References: <5193E6AE dot 8020306 at gmail dot com> <519E75B2 dot 4040000 at gmail dot com> <519E9F88 dot 3010309 at oracle dot com> <51B0F21A dot 9030707 at gmail dot com> <51B8D627 dot 3000203 at gmail dot com> <51C20CDC dot 7040200 at gmail dot com> <CAH6eHdRnJ_tQu5pPM21cSNbtjNpm-YBbb19N1Rt5OrXssGjrng at mail dot gmail dot com>
On 23 June 2013 13:51, Jonathan Wakely wrote:
> On 19 June 2013 20:56, François Dumont wrote:
>> Still no chance to have a look ?
>
> I'll try to finish reviewing it today, thanks for the reminder.
Sorry for the delay. The patch is OK, with a few small changes to the new docs:
Please change "rational" to "rationale"
"can require to update the bucket" should be "can require updating the bucket"
"need to compute following node hash code." should be "need to compute
the following node's hash code."
"won't compute next element hash code" should be "won't compute the
next element's hash code"
"bench" should be "benchmark"
I would say "more harm than good" instead of "more bad than good"
Thanks!