This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, updated] Vtable pointer verification, runtime library changes (patch 3 of 3)

From: Caroline Tice <cmtice at google dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>, Luis Lozano <llozano at google dot com>, Bhaskar Janakiraman <bjanakiraman at google dot com>
Date: Thu, 7 Mar 2013 15:53:20 -0800
Subject: Re: [PATCH, updated] Vtable pointer verification, runtime library changes (patch 3 of 3)
References: <CABtf2+Rg+E+mt1CsWbDd=we0en7--YTLFTP6FZduhag5zL_uXA@mail.gmail.com> <CABtf2+Q4v3yRycHfgqN10K6JrX_8mkaREFLTbws=G8OEH=GN+w@mail.gmail.com> <CAH6eHdRJKgQUn59iB4VFoHDBV25zqMVMA=Cc3q++75PpmjuV7w@mail.gmail.com>

Hello,

I believe this patch addresses all of your comments; I modified the
configure.ac files to generate the configures, and I fixed the
spelling mistakes in the comments.  I still get the warnings when
generating the Makefile.in files from the Makefile.am files, but the
resulting files seem to be correct, and I don't know how to make the
warnings go away.

Please review this patch and let me know if it will be ok to commit
when GCC opens up again.

-- Caroline Tice
cmtice@google.com

ChangeLog (toplevel):
2013-03-07  Caroline Tice  <cmtice@google.com>

	* configure.ac (CXX_FOR_TARGET,RAW_CXX_FOR_TARGET): Add
	libstdc++-v3/libsupc++/.libs to the library search path.
	* configure: Regenerate.


ChangeLog (libstdc++-v3):
2013-03-07  Caroline Tice  <cmtice@google.com>

	* configure: Regenerate.
	* src/Makefile.in: Regenerate.
	* src/c++98/Makefile.am (EXTRA_VTV_LDFLAGS, LIBVTV_FLAGS, VTV_CXXFLAGS):
	New definitions, conditioned on ENABLE_VTABLE_VERIFY.
	(AM_CXXFLAGS):  Add VTV_CXXFLAGS to list.
	(CXXLINK): Add LIBVTV_FLAGS.
	* src/c++11/Makefile.am: Ditto.
	* src/c++98/Makefile.in: Regenerate.
	* src/Makefile.am (libvtv__la_LIBADD): Add definition, conditioned on
	ENABLE_VTABLE_VERIFY.
	(LIBVTV_FLAGS): Add definition, conditioned on ENABLE_VTABLE_VERIFY.
	(libstdc___la_LDFLAGS): Add 'Wl,-u_vtable_map_var_start,
	-u_vtable_map_var_end' if ENABLE_VTABLE_VERIFY is true.
	(AM_CXXFLAGS): Add VTV_CXXFLAGS.
	(CXXLINK):  Add LIBVTV_FLAGS.
	* src/c++11/Makefile.in: Regenerate.
	* configure.ac (predep_objects_CXX): Add libgcc/vtv_start.o, if
	enable_vtable_verify is yes.
	(postdep_objects_CXX): Add libgcc/vtv_end.o if enable_vtable_verify is
	yes.
	(GLIBCXX_ENABLE_VTABLE_VERIFY): New definition.
	* libsupc++/vtv_set.h:  New file.
	* libsupc++/vtv_stubs.cc:  New file.
	* libsupc++/vtv_utils.cc:  New file.
	* libsupc++/vtv_utils.h:  New file.
	* libsupc++/vtv_init.cc:  New file.
	* libsupc++/vtv_malloc.cc:  New file.
	* libsupc++/Makefile.am (sources):  Add vtv_rts.cc, vtv_malloc.cc and
	vtv_utils.cc to the list.
	(vtv_init_sources, vtv_stubs_soruces, libvtv_init_la_sources,
	libvtv_stubs_la_sources):  New definitions.
	(toolexeclib_LTLIBRARIES):  Add libvtv_init.la and libvtv_stubs.la
	* libsupc++/Makefile.in:  Regenerate.
	* libsupc++/vtv_rts.cc:  New file.
	* libsupc++/vtv_malloc.h:  New file.
	* libsupc++/vtv_rts.h:  New file.
	* libsupc++/vtv_fail.h:  New file.
	* libsupc++/vtv_map.h:  New file.
	* config/abi/pre/gnu.ver:  Add vtable verification runtime functions to
	the list of globally visible symbols.
	* acinclude.m4: Add GLIBCXX_ENABLE_VTABLE_VERIFY option and comments.

Attachment: fsf-vtable-verification.v6.runtime.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH, updated] Vtable pointer verification, runtime library changes (patch 3 of 3)
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]