This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [C++ Patch] for c++/54537
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Fabien Chêne <fabien dot chene at gmail dot com>
- Cc: Jason Merrill <jason at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Wed, 14 Nov 2012 22:14:07 +0100
- Subject: Re: [C++ Patch] for c++/54537
- References: <CAFH4-dhvTpRyzTNpieNnZ=VMDcRE7+wikB4pk3dadFSNs0BK8g@mail.gmail.com> <504D3146.8070108@redhat.com> <CAFH4-dgOgUEgzumgy891xVUieU2vugGxw2=_-_ezdpfXzZV7RQ@mail.gmail.com> <CAFH4-dhcjdoYkxb7gLygQBwv9S02Lue9zoRFE0SBLwemLAc-uQ@mail.gmail.com> <ff93ce3c-2523-42b9-b801-96e667058527@email.android.com> <CAFH4-dhNT8LsqTBuQkRJO9HA+CAbmqQ44OA6PAUusWcn2cWoVg@mail.gmail.com> <a0f17889-3346-4ae9-80c6-28e7e5361f73@email.android.com> <5058FFC4.4020905@oracle.com> <50590293.7050904@oracle.com> <50590676.4090705@oracle.com> <CAFH4-dgRJz5+i4UxRSmGNXkKe6fKLq8Yezw5tosmHjA8tiw7DQ@mail.gmail.com> <505A1002.3040200@oracle.com> <CAFH4-dj3ZQqhrJ93rxMg_z4eZryKRH+j_jsZ7_cX5Wx9E1BGGA@mail.gmail.com>
Hi,
On 11/14/2012 10:04 PM, Fabien Chêne wrote:
My apologize to come back after such a delay. The patch is almost
ready, I was just wondering if we could add the specialization
template<> inline double pow(double __x, double __y) { return
std::pow(__x, __y); } (in tr1/math.h) instead of relying on the
generic version, it passes testing as well. I doubt that it will
change something, but perhaps it could be the case for unoptimized
builds, I don't know (and I didn't take the time to check). Anyway, I
find it a bit unusual, so just take it as a suggestion. I'll submit
the patch with the version that you prefer.
Since we came to the conclusion that removing the overload for (double,
double) worked, let's just do that and be done with it. Then we have a
few months before the release to make sure that we aren't regressing,
safe enough for this legacy TR1 stuff, IMO.
Paolo.