This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] libstdc++/53248
- From: Marc Glisse <marc dot glisse at inria dot fr>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, Daniel Krügler <daniel dot kruegler at gmail dot com>
- Date: Wed, 3 Oct 2012 20:18:58 +0200 (CEST)
- Subject: Re: [v3] libstdc++/53248
- References: <506C66E4.7040008@oracle.com>
- Reply-to: libstdc++ at gcc dot gnu dot org
On Wed, 3 Oct 2012, Paolo Carlini wrote:
thus this is the patch I prepared for this issue, consistently (I hope!) with
the various points discussed in the audit trail, with Daniel too. In
particular: 1- We'd rather prefer not use a specialization; 2- Having begin()
and end() always returning nullptr for zero-sized-arrays is fine.
Of course the patch could be tweaked in various different ways but if nobody
has special suggestions this is the version I'm going to commit.
A quick look gives me the impression that:
1) it breaks the ABI for arrays of dim 0 (I don't mind)
2) it breaks the API by changing the number of levels of {} you need to
add to initialize for instance an array of arrays
3) it uses *p where p is a null pointer (it only builds a reference
though, so that might be ok)
That's a really quick look so I am probably wrong, I just wanted to make
sure it was checked.
--
Marc Glisse