This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] constexpr array additions
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: FranÃois Dumont <francois dot cppdevs at free dot fr>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Tue, 2 Aug 2011 10:10:50 -0700
- Subject: Re: [v3] constexpr array additions
- References: <20110720214323.0d0d8a3e@shotwell> <4E29E0BD.5010901@free.fr> <20110725122207.5c9d1c17@shotwell> <20110725212413.7af77b8c@shotwell> <4E35AC22.7000101@free.fr>
> I think the -fno-exceptions should be removed from the test
> dg-options. Otherwise your comment saying that the 'at' should throw
> or abort is wrong. I think the testsuite logic is to write neutral
> tests and challenge them with numerous different combination of
> options. I guess the testsuite is run with -fno-exceptions option
> before a release, no ?
Yeah. You are right. Will fix: thanks for the comments.
> Moreover you are testing the mutable at method, not the const
> one involved in the patch, we should have a second test case.
Ouch. Thanks for catching this.
-benjamin