This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: update debug checks

Thank you, I was about to submit an other attempt but I surely wouldn't have done better.

Ok for the remark on how to submit ChangeLogs. I already noticed that the last entry you paste for me in ChangeLog contains spaces rather than tabs.

I didn't submit patch from libstdc++-v3 because I am already working on generalization of my patch to algos. It took me more time than expected, the post will come soon.

Regards

On 09/03/2010 08:17 PM, Paolo Carlini wrote: 
... I went ahead and committed the below. Tested x86_64-linux, make
check, make check-debug.

For your future submissions, remember to diff from libstdc++-v3, not
testsuite or any other subdir. Also please *attach* the ChangeLog entry,
like the patch, this way it's easier to take it out from the message
while preserving the formatting.

Thanks again!
Paolo.

PS: if you look at SVN& Bugzilla, a long thorny story led to the
previous check_v3_target_debug_mode, stories having to do with weak
support on AIX. I think you did the right thing, and that these issues
do not affect anymore the currently supported AIX versions, but in
general we should be a tad more careful in such areas. Otherwise after a
couple of months we risk having to do with reported regressions on less
frequently tested arches...

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]