This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
[patch, libstdc++, testsuite] Modify tests to use tmpnam()
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 3 Mar 2010 13:35:56 -0800 (PST)
- Subject: [patch, libstdc++, testsuite] Modify tests to use tmpnam()
- Reply-to: sje at cup dot hp dot com
I took a look at two libstdc++ tests that are failing for me on IA64
HP-UX and found that the problem was related to running the tests over
NFS. Both tests are using mkfifo to create pipe's in the current
working directory and that works for me on a local filesystem but fails
over NFS. I am not sure if that is an HP-UX bug or not, but I would
like to change the tests to use tmpnam to create the pipes, this fixes
the problem on IA64 HP-UX and causes no regressions. There are already
tests (27_io/headers/cstdio/macros.cc and
27_io/headers/cstdio/functions_std.cc) that check for the existence of
the L_tmpnam macro and the tmpnam function so using them in these
tests shouldn't be a problem.
OK for checkin?
Steve Ellcey
sje@cup.hp.com
2010-03-03 Steve Ellcey <sje@cup.hp.com>
* testsuite/27_io/objects/wchar_t/7.cc: Use tmpnam.
* testsuite/27_io/objects/wchar_t/9661-1.cc: Ditto.
Index: testsuite/27_io/objects/wchar_t/7.cc
===================================================================
--- testsuite/27_io/objects/wchar_t/7.cc (revision 157186)
+++ testsuite/27_io/objects/wchar_t/7.cc (working copy)
@@ -44,7 +44,8 @@ bool test07()
using namespace __gnu_test;
bool test __attribute__((unused)) = true;
- const char* name = "tmp_fifo4";
+ char name[L_tmpnam];
+ tmpnam(name);
signal(SIGPIPE, SIG_IGN);
Index: testsuite/27_io/objects/wchar_t/9661-1.cc
===================================================================
--- testsuite/27_io/objects/wchar_t/9661-1.cc (revision 157186)
+++ testsuite/27_io/objects/wchar_t/9661-1.cc (working copy)
@@ -44,7 +44,8 @@ bool test01()
bool test __attribute__((unused)) = true;
- const char* name = "tmp_fifo5";
+ char name[L_tmpnam];
+ tmpnam(name);
signal(SIGPIPE, SIG_IGN);