This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed patch


Hello Rainer,

* Rainer Orth wrote on Wed, Feb 24, 2010 at 02:01:59PM CET:
> The following patch has remained unreviewed for about a month:
> 
> 	PATCH: Fix libstdc++ testsuite on systems without ranlib (PR libstdc++/32499)
>         http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00139.html
> 
> It probably needs both a build and a libstdc++ maintainer for review.

This:

--- a/libstdc++-v3/testsuite/Makefile.am        Mon Jan 25 10:22:04 2010 +0000
+++ b/libstdc++-v3/testsuite/Makefile.am        Wed Feb 03 19:26:03 2010 +0100
@@ -103,6 +103,8 @@
 
 # Run the testsuite in normal mode.
 check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp
+       AR=$(AR); export AR; \
+       RANLIB=$(RANLIB); export RANLIB; \

would probably be safer if the $(AR) and $(RANLIB) were enclosed in
quotes, in case some user uses RANLIB="ranlib -t" or so.

Other than that, I cannot really judge the patch.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]