This is the mail archive of the
mailing list for the libstdc++ project.
Re: [PATCH 2/N] LIBTOOLFLAGS, and *_LINK fixes for Automake 1.11
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Fri, 28 Aug 2009 14:55:29 +0100
- Subject: Re: [PATCH 2/N] LIBTOOLFLAGS, and *_LINK fixes for Automake 1.11
- References: <20090815112928.GB5396@gmx.de> <20090815113216.GB20172@gmx.de>
Ralf Wildenhues wrote:
>> - LIBTOOLFLAGS, and *_LINK fixes for Automake 1.11 (GCC only)
> Automake handling of per-target LDFLAGS rules changed which means
> that if you override *_LINK manually, you have to ensure that they
> are used, too.
> Automake introduced $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS)
> (or per-target LIBTOOLFLAGS). Add them where we manually override
> $(LINK). Also, add $(LIBTOOLFLAGS) where we use $(LIBTOOL) in
> Makefile.in files not governed by automake.
> When this patch is used with Automake 1.9.6, there is a small chance for
> problems: its rules may now cause duplicate expansion of some of the
> link flags. If link flags duplication is a problem on some systems,
> then this can cause failures. I haven't tested this much.
> OK to apply?
Is it possible that this patch is related to a problem I'm experiencing on
HEAD (r151124) where LTLDFLAGS in libstdc++-v3/src appears no longer to be
used in the final link of libstdc++.la?
It used to be that LTLDFLAGS was included in CXXLINK, which was used in the
rule for linking libstdc++.la, but now that rule uses libstdc___la_LINK
instead. Is it perhaps the case that both LTLDFLAGS and CXXLINK are now
obsolete in the v3 makefiles and don't need to be defined at all?