This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [gcc 4.5 patch] Permit smaller hash tables for hash_map and hash_set
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, iant at google dot com
- Date: Tue, 24 Feb 2009 08:51:22 -0800
- Subject: Re: [gcc 4.5 patch] Permit smaller hash tables for hash_map and hash_set
- References: <m3r62bgna6.fsf@google.com> <20090223125703.49c3ea7f@redhat.com>
Hi,
I have a few patches to make them better in some circumstances.
These
ideas are incorporated in different from in the newer unordered_set
and unordered_map. However, existing code still uses hash_map and
hash_set, so it may be useful to update them if we think that is OK.
I believe there was a previous attempt to fix up this stuff. It was
not
well-received, although I don't especially remember the details. At
this
point, I think this kind of stuff should just be checked in.
Well, probably I'm the one not receiving well that kind of change in
the past ;) Really, I'm still of the same opinion, that code should be
just frozen by now, we do *not* want to deal with regressions, at
least, certainly not me. In the case at issue, I have also some small
concerns from the point of view of binary compatibility: are we really
sure that two different binaries built before and after this change
can interoperate smoothly?
Thanks,
Paolo.