Re: [PATCH] mips64-linux-gnu abi_check issues

[Adam Nemet <anemet at caviumnetworks dot com>]

Adam Nemet writes:
> Joseph S. Myers writes:
> > sqrtl *is* provided by glibc for MIPS64, ever since:
> > 
> > 2007-05-23  Joseph Myers  <joseph@codesourcery.com>
> > 
> >         * sysdeps/mips/mips64/n32/Implies: Add mips/mips64/soft-fp.
> >         * sysdeps/mips/mips64/n64/Implies: Likewise.
> >         * sysdeps/mips/mips64/soft-fp/Makefile: New.
> >         * sysdeps/mips/mips64/soft-fp/e_sqrtl.c: New.
> >         * sysdeps/mips/mips64/soft-fp/sfp-machine.h: Include <fenv.h> and
> >         <fpu_control.h>.  Use hardware exception and rounding mode
> >         settings.
> 
> Thanks, that's good to know.  We're in the process of moving to glibc 2.9 so I
> can try with that and remove sqrtl if it works.  I will report back.

Here is the updated patch with sqrtl removed.  Both abi_check and
bootstrapping still pass with the new patch (on glibc 2.9).

This is the new diff against mips-linux:

--- config/abi/post/mips-linux-gnu/baseline_symbols.txt	2008-07-13 21:04:38.000000000 -0700
+++ config/abi/post/mips64-linux-gnu/baseline_symbols.txt	2009-02-05 11:53:48.000000000 -0800
@@ -2273,28 +2273,6 @@
 FUNC:__cxa_vec_new@@CXXABI_1.3
 FUNC:__dynamic_cast@@CXXABI_1.3
 FUNC:__gxx_personality_v0@@CXXABI_1.3
-FUNC:acosl@@GLIBCXX_3.4.3
-FUNC:asinl@@GLIBCXX_3.4.3
-FUNC:atan2l@@GLIBCXX_3.4
-FUNC:atanl@@GLIBCXX_3.4.3
-FUNC:ceill@@GLIBCXX_3.4.3
-FUNC:coshl@@GLIBCXX_3.4
-FUNC:cosl@@GLIBCXX_3.4
-FUNC:expl@@GLIBCXX_3.4
-FUNC:floorl@@GLIBCXX_3.4.3
-FUNC:fmodl@@GLIBCXX_3.4.3
-FUNC:frexpl@@GLIBCXX_3.4.3
-FUNC:hypotl@@GLIBCXX_3.4
-FUNC:ldexpl@@GLIBCXX_3.4.3
-FUNC:log10l@@GLIBCXX_3.4
-FUNC:logl@@GLIBCXX_3.4
-FUNC:modfl@@GLIBCXX_3.4.3
-FUNC:powl@@GLIBCXX_3.4
-FUNC:sinhl@@GLIBCXX_3.4
-FUNC:sinl@@GLIBCXX_3.4
-FUNC:sqrtl@@GLIBCXX_3.4
-FUNC:tanhl@@GLIBCXX_3.4
-FUNC:tanl@@GLIBCXX_3.4
 OBJECT:0:CXXABI_1.3
 OBJECT:0:CXXABI_1.3.1
 OBJECT:0:CXXABI_1.3.2

OK?

Adam

	* configure.host: Set abi_baseline_pair for mips64*-linux.
	* config/abi/post/mips64-linux-gnu/baseline_symbols.txt: New file.

Attachment: libstdc++-mips64-abi-check-2.patch.bz2
Description: Binary data