This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][libstdc++-v3 parallel mode] Fix parallel functions not called by default
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Johannes Singler <singler at ira dot uka dot de>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 03 Feb 2009 15:52:05 +0100
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] Fix parallel functions not called by default
- References: <49884C36.6050809@ira.uka.de>
Hi,
> The first patch fixes a bug that made some functions being exectued
> sequentially by default, although _GLIBCXX_PARALLEL was switched on.
> It dates back to this thread:
>
> <http://gcc.gnu.org/ml/libstdc++/2008-09/msg00116.html>
>
> The second patch fixes regressions that came up because of the better
> test coverage due to the first patch. The bugs were there before. And
> overall, only the experimental parallel mode is affected, there is no
> change for the normal case.
>
> Tested x86_64-unknown-linux-gnu: No regressions
>
> Please approve for mainline and gcc-4_3-branch. I know that GCC 4.4
> currently is in a late stage, but this patch is important for the
> parallel mode, and it only affects an experimental part.
> In case of approval, commit together or separate?
>
if you can confirm indeed that the patches cause no regressions both in
normal mode and in parallel mode, then Ok for mainline, please commit
both at once. Let's wait a bit for 4_3-branch.
Thanks!
Paolo.