Re: Reworked nonstd pointer patch

[Bob Walters <mostlyharmless77 at yahoo dot com>]

Paolo,

Here's a revision of nonstd_pointer.path with the issues you mentioned  
addressed.

Attachment: nonstd_pointer.patch
Description: Binary data

Specifically:

> > I see many unuglifed names, like T, arg, rarg, _U (should be _Up).
Uglified to _Tp, __arg, __rarg, _Up, also found some others: __unused,  
__p.

> Also, the testcases are in nonstd_pointer/, I think now should
> be something else, consistent with the rename, like ext_pointer.
Done for both vector/nonstd_pointer, and ext/nonstd_pointer.  Both  
renamed to ext_pointer.

> Also,
> we don't constify by value arguments, thus, for example, _FromType *
> const arg should be just _FromType* arg.
Done.  I saw this is cast.h, and operator<< in pointer.h, but nowhere  
else.

> Also make sure that & and *
> stay with the type of the argument, e.g., const _ExtPtr_allocator
> &__rarg should be const _ExtPtr_allocator& __rarg.
Done.  (Many occurrences)

> Finally, do not
> append _ to names,
Only saw this in extptr_allocator's include guard.  grepped for other  
occurances, found none.

> and do not prepend GCC, _EXT_CAST, not _GCC_EXT_CAST.
Fixed in pointer.h, cast.h, extptr_allocator.h.  NOTE: also removed  
GCC prefix from
macros used in pointer.h to similarly meet this convention.

> Last but not least, a ChangeLog entry is missing.
Added an entry.