This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3] c++0x <mutex> and <condition_variable>


On Wed, Sep 3, 2008 at 11:26 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
>
>>> Ok. Patch now looks great. A minor nit: can you resend a version making
>>> sure that dg-do compile is always the *first* dg-* directive in the
>>> testfile? I'm sure I saw spurious fails otherwise...
>>

Checked them all again. I think the dg-do's are first in all testcases now.

>> I'm sorry, another one: timed_mutex/try_lock/2.cc doesn't have the full
>> dg-do run / dg-options dance, is it intended?
>

Unintentional. Fixed.

> ... and, assuming that doesn't create problems with the dg-error line
> numbers, you can as well mark inline the various non-member swaps...
>
> Paolo.
>

Done. I also added explicit bool casts to unique_lock test cases where
the bool conversion operator is being used since the operator itself
is suppose to be explicit (unimplemented c++0x feature).

Attached updated patch and changelog.

Chris

Attachment: Changelog_mutex_cond_var.txt
Description: Text document

Attachment: mutex_cond_var_patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]