This is the mail archive of the
mailing list for the libstdc++ project.
Re: [RFC] parallel/tree.h?
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org
- Date: Thu, 1 May 2008 10:22:00 -0500
- Subject: Re: [RFC] parallel/tree.h?
- References: <481833E4.email@example.com>
> We now have a version ready that activates the parallel tree code.
> Find the patch attached. AFAICS, there are no regressions with
> respect to the testsuite, except one, which is related to the movable
> stuff (see other mail) a "singular" iterator. But where does a
> singular iterator appear in
> FAIL: 23_containers/map/modifiers/insert/16813.cc execution test
I am not quite sure, at the moment. But, this is not a blocker I don't
> Ok, so what has to be done to the code in order to get accepted
> (except the formatting, of course)?
> Splitting up into smaller pieces? More documentation?
A ChangeLog entry would be nice...
Don't really see any documentation in this patch.
So yes. You need to at least mention in
doc/xml/manual/parallel_mode.xml that you have these types.
You posted an include/Makefile.in diff, but the actual file that would
be edited would be include/Makefile.am. (There is no need to post the
diff of the auto-generated Makefile.in)
> The algorithm itself is documented here:
Should be mentioned as a comment in the sources file.