This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++-v3 parallel mode] Clean up loser tree and multiway_merge code


Hello Johannes,

a few typo nits:

* Johannes Singler wrote on Thu, Apr 03, 2008 at 06:34:01PM CEST:
>
> +        // Move the sequends end behind the sentinel spots.  This has the

s/sequends/sequence/ ?

> +        // effect that the sentinel appears to be within the sequence. Then,
> +        // we can use the unguarded variant if we merge out as many
> +        // non-sentinel elements as we have.

> +/**
> + * @brief Traits for determining whether the loser tree should
> + *   use pointers or copies.
> + *
> + * The field "use_pointer" is used to determine whether to use pointers in
> + * the loser trees or whether to copy the values into the loser tree.
> + *
> + * The default behviour is to use pointers if the data type is 4 times as

s/behviour/behaviour/


> +  /**
> +   * @brief True iff to use pointers instead of values in loser trees.
> +   *
> +   * The default behviour is to use pointers if the data type is four

Likewise.

> +   * times as big as the pointer to it.
> +   */

> +/**
> + * @brief Stable sorting functor.
> + *
> + * Used to reduce code instanciation in multiway_merge_sampling_splitting.

s/instanciation/instantiation/


> +/**
> + * @brief Non-stable sorting functor.
> + *
> + * Used to reduce code instanciation in multiway_merge_sampling_splitting.

Likewise.

> +/**
> + * @brief Guarded loser/tournament tree.
> + *
> + * The smallest element is a the top.

s/a/at/

> + *
> + * Guarding is done explicitly through one flag sup per element,
> + * inf is not needed due to a better initialization routine.  This
> + * is a well-performing variant.
> + *
> + * @param T the element type
> + * @param Comparator the comparator to use, defaults to std::less<T>
> + */

> -    }
> +  /**
> +   * @brief The desctructor.

s/desctructor/destructor.

> +   */
> +  ~LoserTreeBase()
> +  { ::operator delete(losers); }

> +  /**
> +   * Delete the key smallest element and insert the element key instead.
> +   *
> +   * @param key the key to insert
> +   * @param sup true iff key is an explicitely marked supremum

s/explicitely/explicitly/

> +   */
> +  // Do not pass const reference since key will be used as local variable.

s/const/a const/ ?

> +  inline void
> +  delete_min_insert(T key, bool sup)

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]