This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: vterminate use of malloc-less demangler
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, simonb at google dot com
- Date: Tue, 25 Mar 2008 14:06:17 -0500
- Subject: Re: vterminate use of malloc-less demangler
- References: <m3k5jqactu.fsf@google.com>
> The proposed patch is just using the existing callback interface from
> libiberty. It is fairly short, adding 19 lines in one hunk and
> removing 6 in the other. Does anybody object to it?
As one of the objectors, I will no longer stand in the way of this
patch. I believe it does solve issues with the current behavior of
__verbose_terminate_handler.
I consider better a better public interface to cxxabi.h's
__cxa_demangle function an open issue, and one not addressed by this
patch directly (since __gcclibcxx_demangle_callback is not public.)
It would be nice to have a testcase for the failure mode. If integrating
this seems difficult (it did during the last review), maybe you can
just put in a more elaborate comment in vterminate.cc by the
__gcclibcxx_demangle_callback declaration. Seem reasonable?
best,
benjamin