This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][libstdc++-v3 parallel mode] Default constructor/placement new issues
- From: Johannes Singler <singler at ira dot uka dot de>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Wed, 28 Nov 2007 18:39:29 +0100
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] Default constructor/placement new issues
- References: <474D8D93.6030707@ira.uka.de> <20071128100645.123a46c2@concorde.artheist.org>
Benjamin Kosnik wrote:
> Before you check this patch in, can you comment the one remaining place?
> Something like
>
> // XXX incorrect (de)construction
>
> would be perfect.
Done.
>> 2007-11-28 Johannes Singler <singler@ira.uka.de>
>>
>> * include/parallel/multiway_merge.h:
>> Destruct only elements that were have been constructed
>> before Code beautifying and formatting
>
> * include/parallel/multiway_merge.h: Destruct only elements
> that were have been constructed before. Code beautifying and
> formatting.
>
> End with a period.
> For the ChangeLog entry, try to match the emacs-centric formatting that
> other entries use: this looks a little off, but maybe it's just
> cut-paste or mailer error.
Okay.
=> Committed.
-- Johannes