Re: [PATCH][libstdc++-v3 parallel mode] PR 33893 work correctly even if omp_get_dynamic()

[Paolo Carlini <pcarlini at suse dot de>]

Johannes Singler wrote:
> I'm aware of that, and got a pointer to a detailed instruction on how to
> do that by Benjamin Kosnik only recently. I already tried to format the
> changed parts according to the guidelines. About the indentation: Is
> there a really good tool that does it well? What would the options for
> GNU indent be?
>   
Frankly, I don't know the details, because I'm using emacs and
everything is ok by default.
> Concerning the "uglification": I would like to postpone that after other
> changes, because as the word implies, the code gets much harder to read
> and to maintain.
>   
Eh, eh, I'm not sure I agree, you have only to get used to that, after a
few years you start using underscores also for user code, it really
happens to me ;) And, remember, at variance with the formatting bits,
this is a *conformance* issue: nothing prevents the users to define
macros with the same names which you are using in the library if you
don't add underscores... Sad, but true...
> But you can open up a PR on that, of course.
>   
I don't think there is a need for it, because apparently all the
interested people are aware of the issue...

Paolo.