This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Tweaking atomics and memory barriers in shared_ptr
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 06 Nov 2007 18:21:56 +0100
- Subject: Re: Tweaking atomics and memory barriers in shared_ptr
- References: <4348dea50710270529q461462d8p553339a37fbd9191@mail.gmail.com> <472D9A12.40305@suse.de> <4348dea50711060635t4f3ae028o197c64a8cb03ad26@mail.gmail.com>
Hi Jonathan,
> thanks for the review. I've committed the patch without the new
> _S_single specialisations. They could always be added later if there
> is any demand for a non-threadsafe shared_ptr, and if there isn't
> demand then you're right not to change the code.
>
Totally agreed, thanks again for now.
> With the new memory barrier usage and the comments I added, are you
> happy if I close http://gcc.gnu.org/PR24347 ?
>
Sure. At some point it would be nice to also add something to the docs
proper. I think Benjamin is already at work on a documentation overhaul,
you may want to get in touch with him...
> Now that this patch is done I'll prepare the patch for aliasing and
> allocator support.
>
Great!
Paolo.