This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Make sure symbol version script is writeable
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Tue, 07 Aug 2007 14:06:50 -0700
- Subject: Re: Make sure symbol version script is writeable
- References: <m364741gqm.fsf@codesourcery.com> <jetzuonuix.fsf@sykes.suse.de> <m31whsp1r1.fsf@codesourcery.com> <467D7D64.6020407@codesourcery.com>
Mark Mitchell <mark@codesourcery.com> writes:
> Jim Blandy wrote:
>> Andreas Schwab <schwab@suse.de> writes:
>>> Jim Blandy <jimb@codesourcery.com> writes:
>>>
>>>> If the source tree has been made read-only, the libstdc++-v3 build
>>>> dies trying to construct src/libstdc++-symbols.ver.
>>>>
>>>> libstdc++-v3/ChangeLog:
>>>> 2007-05-07 Jim Blandy <jimb@codesourcery.com>
>>>>
>>>> * libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
>>>> sure the build tree copy of libstdc++-symbol.ver is writeable.
>>>> * libstdc++-v3/src/Makefile.in: Regenerated.
>>>>
>>>> Index: libstdc++-v3/src/Makefile.am
>>>> ===================================================================
>>>> --- libstdc++-v3/src/Makefile.am (revision 124502)
>>>> +++ libstdc++-v3/src/Makefile.am (working copy)
>>>> @@ -32,6 +32,7 @@
>>>> libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
>>>> $(port_specific_symbol_files)
>>>> cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
>>>> + chmod +w ./libstdc++-symbol.ver
>>> You surely mean `symbols' here?
>>
>> Yes, I certainly do. Thanks for the close reading. (This is what I
>> get for working with three branches at once, none of whose patches
>> apply cleanly to the others.)
>
> It doesn't look like this patch was ever applied. With the change
> Andreas has suggested, this is OK after the lockdown.
I've committed this, revised as below:
libstdc++-v3/ChangeLog:
2007-08-07 Jim Blandy <jimb@codesourcery.com>
* src/Makefile.am (libstdc++-symbol.ver): Make
sure the build tree copy of libstdc++-symbol.ver is writeable.
* src/Makefile.in: Regenerated.
Index: libstdc++-v3/src/Makefile.am
===================================================================
--- libstdc++-v3/src/Makefile.am (revision 127275)
+++ libstdc++-v3/src/Makefile.am (working copy)
@@ -32,6 +32,7 @@
libstdc++-symbols.ver: ${glibcxx_srcdir}/$(SYMVER_FILE) \
$(port_specific_symbol_files)
cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
+ chmod +w ./libstdc++-symbols.ver
if test "x$(port_specific_symbol_files)" != x; then \
if grep '^# Appended to version file.' \
$(port_specific_symbol_files) /dev/null > /dev/null 2>&1; then \