Re: [patch][libstdc++ patch][c++ patch] Update mangling and demangling for rvalue references

[Ian Lance Taylor <iant at google dot com>]

"Doug Gregor" <doug.gregor@gmail.com> writes:

> On 29 Jun 2007 17:16:38 -0700, Ian Lance Taylor <iant@google.com> wrote:
> > "Doug Gregor" <doug.gregor@gmail.com> writes:
> >
> > > Index: include/demangle.h
> > > ===================================================================
> > > --- include/demangle.h        (revision 126081)
> > > +++ include/demangle.h        (working copy)
> > > @@ -359,7 +359,10 @@ enum demangle_component_type
> > >       using 'n' instead of '-', we want a way to indicate a negative
> > >       number which involves neither modifying the mangled string nor
> > >       allocating a new copy of the literal in memory.  */
> > > -  DEMANGLE_COMPONENT_LITERAL_NEG
> > > +  DEMANGLE_COMPONENT_LITERAL_NEG,
> > > +  /* C++0x: An rvalue reference.  The one subtree is the type which is
> > > +     being referenced.  */
> > > +  DEMANGLE_COMPONENT_RVALUE_REFERENCE
> > >  };
> >
> > Please put this up just after DEMANGLE_COMPONENT_REFERENCE.
> 
> I can do that. My understanding was that include/demangle.h was a
> public interface, so I planned to put the new enumerator values at the
> bottom to keep the existing values the same.
> 
> If that doesn't mater, it's cleaner to put it under
> DEMANGLE_COMPONENT_REFERENCE, of course.

It is a public interface, but I don't see why the specific existing
values of the enumerators should matter.

Ian