This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Tweak _generic_/ctype_members.cc (do_is(mask, wchar_t) for iswspace

From: Paolo Carlini <pcarlini at suse dot de>
To: Danny Smith <dannysmith at clear dot net dot nz>
Cc: GCC-patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
Date: Wed, 27 Jun 2007 12:09:12 +0200
Subject: Re: Tweak _generic_/ctype_members.cc (do_is(mask, wchar_t) for iswspace
References: <000001c7b7cd$be06e4d0$0b4861cb@anykey>

Hi again,

Is it it worthwhile to allow same "common case" tweak for generic?
It works on cygwin and mingw32. But, to be honest, I have not really
tried to measure a performance effect on those two targets.
2007-06-25 Danny Smith <dannysmith@users.sourceforege.net>

* config/locale/gnu/ctype_members.cc (do_is(mask, wchar_t)) [_GLIBCXX_CTYPE_SPACE_BIT]: Speed-up for the common case of mask == ctype_base::space, * config/os/mingw32/ctype_base.h: (_GLIBCXX_CTYPE_SPACE_BIT): Define * config/os/newlib/ctype_base.h (_GLIBCXX_CTYPE_SPACE_BIT): Define.

for now, I would just go ahead with your patch. A minor nit: for defining _GLIBCXX_CTYPE_SPACE_BIT, os_defines.h seems more suited.

Paolo.

References:
- Tweak _generic_/ctype_members.cc (do_is(mask, wchar_t) for iswspace
  - From: Danny Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]