This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH RFA: Add support for -Wparentheses to the C++ frontend (PR c++/19564)


Benjamin Kosnik <bkoz@redhat.com> writes:

> > This patch includes the fixes to libstdc++ to avoid the new warnings.
> > These are logically separate.  I included them in this patch because
> > they are mechanical, but I can break them out if preferred.
> > 
> > This has been tested with a bootstrap and testsuite run (including
> > libstdc++ testsuite) on i686-pc-linux-gnu.
> 
> Looks good to me.
> 
> I think it might be a good idea to build with -Wparentheses now that
> you've cleaned things up. To do so, you'll need to edit WARN_FLAGS in
> GLIBCXX_EXPORT_FLAGS.
> 
> That part is pre-approved, if you think it's worthwhile.

No need for that change; -Wall already implies -Wparentheses.

(This patch still needs approval from a C frontend maintainer and a
C++ frontend maintainer.)

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]