This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: TR1 Math tarball
- From: Ed Smith-Rowland <3dw4rd at verizon dot net>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: Benjamin Kosnik <bkoz at redhat dot com>, libstdc++ at gcc dot gnu dot org
- Date: Mon, 04 Dec 2006 21:35:52 -0500
- Subject: Re: TR1 Math tarball
- References: <45666DE0.10306@verizon.net> <20061204122309.73c31f7d.bkoz@redhat.com> <457420B7.6080301@suse.de>
Paolo Carlini wrote:
Benjamin Kosnik wrote:
Here is the latest tarball of the TR1 math patch.
It was merged and bootstrapped just earlier today so it should be OK
to play with.
Nice!
This should definitely go into mainline at your earliest convenience.
Wait a bit more, please, I'm still trying to find the time to review
the substance of it. Among other things, there is the pending issue
with the usage of std::tr1::cmath facilties not protected with
_GLIBCXX_USE_C99_MATH_TR1. Also, quickly, many hard wired constants
related to the precision of the float types which certainly cannot be
ok for machines with 128 bits long double, for example. But really,
please allow me a couple of days to comment, thanks.
Paolo.
I'm putting together another patch in which the floating point
tolerances are replaced by usage of std::numeric_limits<>::stuff().
There are still some integer loop limits but these are more sane.
This patch also has several substantive algorithmic improvements to some
of the
The is the _Private:: to __detail:: change has is done (I noticed this
in <random>).
I'll do the TR1_ for the header guards.
I was asked to post what I had so we could talk about it.
I am finding time for this after a long break.
But I also agree that we are coming up on a point of diminishing returns
for me hacking on it alone and flinging tarballs around. It would be
nice to have most of 4.3 to stomp on it (9 months at the going rate.)
Finally, I do have some issue with using std::tr1::mathfunction. I put
guards around but where is _GLIBCXX_USE_C99_MATH_TR1 defined? I'd like
to fix this.
There are two classes of testcase that I would like:
1) Checks that the nan's and throws are coming out at the right points.
2) Spot checks of selected numeric values.
Ed