This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: -fvisibility-inlines-hidden for x86-darwin builds
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Howard Hinnant <hhinnant at apple dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 24 Oct 2006 12:04:23 +0200
- Subject: Re: -fvisibility-inlines-hidden for x86-darwin builds
- References: <F0126129-CC06-4318-9015-A28E91212911@apple.com>
I assume this means Apple is using the visibility support in 4.2+? If
so, any feedback on the implementation would be useful for the rest of
us.
> 2006-10-23 Howard Hinnant <hhinnant@apple.com>
>
> * libstdc++-v3/configure, libstdc++-v3/acinclude.m4
> Allow OPTIMIZE_CXXFLAGS to be set by configure.host.
> * libstdc++-v3/configure.host
> Set OPTIMIZE_CXXFLAGS to -fvisibility-inlines-hidden
> for x86/darwin
This is fine. Usually you don't include auto-generated files in the patch.
So, you'd have:
* libstdc++-v3/acinclude.m4:
Allow OPTIMIZE_CXXFLAGS to be set by configure.host
* libstdc++-v3/configure: Regenerated.
Please add a comment in acinclude.m4 about setting OPTIMIZE_CXXFLAGS in
configure.host.
best,
benjamin