This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [RFA] Allowing in|out|app
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Sat, 30 Sep 2006 11:06:35 +0200
- Subject: Re: [RFA] Allowing in|out|app
- References: <451AFDE9.9070204@suse.de>
Paolo Carlini wrote:
Basing on that, assuming nobody posts contrary opinions to the LWG
mailing list during the next few days, I'm considering enabling those
modes for our implementation too, as an extension, which, I believe,
would be appreciated by our users.
The below is the patch, already tested on x86-linux, goes in before the
end of the week...
Paolo.
//////////////
2006-09-30 Paolo Carlini <pcarlini@suse.de>
* config/io/basic_file_stdio.cc: As an extension, and
consistently with C facilities, allow for in|out|app and
in|out|app|binary openmodes.
* testsuite/27_io/basic_filebuf/open/char/4.cc: New.
Index: testsuite/27_io/basic_filebuf/open/char/4.cc
===================================================================
--- testsuite/27_io/basic_filebuf/open/char/4.cc (revision 0)
+++ testsuite/27_io/basic_filebuf/open/char/4.cc (revision 0)
@@ -0,0 +1,51 @@
+// 2006-09-29 Paolo Carlini <pcarlini@suse.de>
+
+// Copyright (C) 2006 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING. If not, write to the Free
+// Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+// USA.
+
+#include <fstream>
+#include <testsuite_hooks.h>
+
+// As an extension to Table 92, consistently with the C standards, we also
+// allow in|out|app and in|out|app|binary.
+void test01()
+{
+ bool test __attribute__((unused)) = true;
+ const char* name = "tmp_file4";
+
+ std::fstream scratch_file;
+
+ scratch_file.open(name, std::ios_base::in | std::ios_base::out
+ | std::ios_base::app);
+ VERIFY( scratch_file );
+ VERIFY( scratch_file.is_open() );
+ scratch_file.close();
+
+ scratch_file.open(name, std::ios_base::in | std::ios_base::out
+ | std::ios_base::app | std::ios_base::binary);
+ VERIFY( scratch_file );
+ VERIFY( scratch_file.is_open() );
+ scratch_file.close();
+}
+
+int
+main()
+{
+ test01();
+ return 0;
+}
Index: config/io/basic_file_stdio.cc
===================================================================
--- config/io/basic_file_stdio.cc (revision 117283)
+++ config/io/basic_file_stdio.cc (working copy)
@@ -95,6 +95,8 @@
case (in ): return "r";
case (in|out ): return "r+";
case (in|out|trunc ): return "w+";
+ // Extension to Table 92.
+ case (in|out |app ): return "a+";
case ( out |binary): return "wb";
case ( out |app|binary): return "ab";
@@ -102,6 +104,8 @@
case (in |binary): return "rb";
case (in|out |binary): return "r+b";
case (in|out|trunc |binary): return "w+b";
+ // Extension to Table 92.
+ case (in|out |app|binary): return "a+b";
default: return 0; // invalid
}