This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][RFC] Remove volatile from data members in libstdc++
On Wed, 12 Jul 2006, Paolo Carlini wrote:
> Hi Richard,
>
> >Needs the typo fix below. I wonder if this is an ABI change?
> >
> >
> I'm afraid it is, because you are changing the struct _Refcount_Base, at least
> its size. Not to mention interoperability between one object using mutexes and
> another using atomic operations...
Indeed. The volatiles can be removed on the mainline though.
> >Tested on x86_64-unknown-linux-gnu.
> >
> >Ok for mainline?
> >
> >
> Please wait a few hours in case Hans has something to add, then commit to
> v7-branch.
>
> Thanks a lot!
> Paolo.
>
> P.S. When MT is involved, usually I regtest on a multi-way machine, like one
> among the 4-way ia64 and x86-64 machines of our internal network...
I did. But rope testsuite coverage is not exactly interesting ;)
Richard.
--
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs