Re: tr1 random

[Benjamin Kosnik <bkoz at redhat dot com>]

Hey Stephen: nice to hear from you.

> I've been trying to clean up my backlog of stuff and came across my attempt at 
> the tr1::random stuff.  As a first draft of a submission I've removed the 
> stuff I know doesn't yet work (subtract_with_carry_01 and some of the 
> continuous distributions) on the grounds that a partial implementation is 
> better than no implementation.  I'm posting this for a quick review, since 
> it's been about a year since I wrote it so I'm probably missing something.  
> I'm just trying to get the ball rolling here.

Let's get it rolling!

This looks good to me: let's get this in without further delay. From
the paperwork side, you're all set and your assignment is in good
standing. Once it's in the repository, it'll be easier for more people
to hack on it.

> I'm also new to this subversion thing and trying to figure out how to get a 
> proper diff, so here's a diff of the include/Makefile.am and a tarball of the 
> new files including testsuite.

This is sufficient for the initial check in, I think.

I found the gcc wiki pages quite helpful for the subversion change.
Here's the links that I used to get up to speed:

http://gcc.gnu.org/wiki/SvnHelp
http://gcc.gnu.org/wiki/SvnBasic

for the diff bits, see:
http://gcc.gnu.org/wiki/SvnTricks

and look for "How do I configure an external diff tool?"

However, if you'd like Paolo or I to do the initial check in, just let
us know. I am perfectly willing to do this for you if you'd find it
easier.

best,
benjamin